trouble freezing layers with activex

Don't have time to mess with this all day. I'm trying to freeze all layers
(except the active layer). Using the code below, my routine reports that
none of the layers can be frozen. What am I missing.

(setq $acad (vlax-get-acad-object)) ;get acad object
(setq $doc (vla-get-activedocument $acad)) ;get active document object
(setq $laytbl (vla-get-layers $doc)) ;get layers collection
(vlax-for item $laytbl ;for each item in the layers collection
(progn
...
(if (vl-catch-all-error-p (vl-catch-all-apply 'vla-put-freeze '(item
:vlax-true)))
(princ (strcat "\nCan't freeze layer " (vla-get-name item)))
);end if
...
);end progn
);end vlax-for

 

Yes. I realize that. But I am trying to improve upon routines that someone
else wrote using that method. Using "command" in a lisp is not true lisp...
it is scripting. All things being equal VLisp routines will typically
execute faster than vanilla lisp or scripts too.

 

Not in THAT much of a rush. What I meant was that I don't have the time to
make it work right now, because of other commitments. But I would like to
get it working without resorting to using "command". I try to stay away
from using that whenever possible. See my reply Kent C. for more info.

 

Before anybody else replies with "try this other method", and without
stepping on the toes of those that already ahve suggested it:

I am trying to make this work using ony vlisp. I'm trying to speed up and
improve upon code already written by another individual. I don't care if it
is more complex to code using vlisp. It will run much faster than scripting
with the layer command, or plain vanilla lisp.

I'm a bit of a purist: once I start a routine with a language, or
programming style, I don't like to jump to another mid-routine.

 

Well, you need to remember that passing a list with the quote, ala '(item
:vlax-true), causes lisp to interpret each symbol literally. Try changing
that to (list item :vlax-true)

HTH,

 

Since I once believed this, you may want to read the entire thread at:
http://theswamp.org/phpBB2/viewtopic.php?t=1449

It was a real eye opener for me.......

Jeff

 

or another option is

(vlax-for item $laytbl ;for each item in the layers collection
(if (= (getvar "clayer") (vla-get-name item))
(princ (strcat "\nCan't freeze layer " (vla-get-name item)))
(putx item 'Freeze -1)
);end if
);end vlax-for

Tim

 

Excellent! That worked. Wasn't think about the quote being the problem.

It's funny that you suggested that just as I found this method that also
works.

(if (/= (vla-get-name item) (getvar "clayer"))
(vla-put-freeze item :vlax-true)
)

That reminds me... is there a way to find the current (active) layer using
activex? Doesn't seem to be a method or propety in the layers collection
for that.

 

(vla-get-name (vla-get-activelayer $doc))

 

Your problem is simple... you quoted the list so that item is not evaluated.
Construct the list instead.
(vl-catch-all-apply 'vla-put-freeze (list item :vlax-true))

But you shouldn't need to catch any items.
Presuming your $doc is global...
(setq ActiveLayer (vlax-get $doc 'ActiveLayer))
(vlax-for Layer (vlax-get $doc 'Layers)
(or
(equal Layer ActiveLayer)
(vlax-put Layer 'Freeze -1)
)
)