cloud

Could anyone tell me why this is crachinf when Freehand is selected..

(defun MyExit (strErr)
(setvar "clayer" clay)
(setvar "osmode" oldos)
(command "undo" "1")
(princ)
)

(defun c:Rcloud ()
(setq SP "Freehand")
(while (= SP "Freehand")
(initget 1 "Freehand")
(setq SP (getpoint "\nSpecify first point or [Freehand]: "))
(IF (= SP "Freehand")
(rcloud1)
)
)
(setq *ERROR* MyExit)
(setq oldecho (getvar "cmdecho")
oldim (getvar "dimscale")
Clay (getvar "clayer")
oldos (getvar "osmode")
)
(setvar "osmode" 0)
(command "-layer" "m" "REV_CLOUD" "")
(command "-layer" "c" "8" "" "")
(prompt
"\nPick cloud boudary: <enter or right click> to finish: "
)
(command "pline")
(while (> (getvar "CmdActive") 0)
(command pause)
(prompt
"\nPick next point: <enter or right click> to finish: "
)
)
(command "pedit" "l" "cl" "")
(setq chkscale (getvar "cvport"))
(if (= chkscale 1)
(setvar "dimscale" 1)
)
(setq bubscale (getvar "dimscale")
bubsc (* bubscale 20)
)
(command "revcloud" "a" bubsc bubsc "o" "last" "")
(setvar "clayer" clay)
(setvar "osmode" oldos)
(setvar "dimscale" oldim)
(PRINC)
)

(defun rcloud1 (/ chkscale bubscale bubsc)
(setq *ERROR* MyExit)
(setq oldecho (getvar "cmdecho")
oldim (getvar "dimscale")
Clay (getvar "clayer")
oldos (getvar "osmode")
)
(setvar "osmode" 0)
(command "-layer" "m" "REV_CLOUD" "")
(command "-layer" "c" "8" "" "")
(setq chkscale (getvar "cvport"))
(if (= chkscale 1)
(setvar "dimscale" 1)
)
(setq bubscale (getvar "dimscale")
bubsc (* bubscale 10)
)
(command "revcloud" "a" bubsc bubsc)
(setvar "clayer" clay)
(setvar "osmode" oldos)
(setvar "dimscale" oldim)
(princ)
)

 

sorted it, any suggestions for improvment (layout etc.)



(defun MyError (strErr)
(command "undo" "1")
(setvar "clayer" templay)
(setvar "osmode" oldos)
(setvar "dimscale" oldim)
(princ "-cloud cancelled by user-")
(princ)
)


(defun c:rCLOUD ()
(setq oldim (getvar "dimscale")
templay (getvar "clayer")
oldos (getvar "osmode")
)
(setq *ERROR* MyError)
(command "-layer" "m" "REV_CLOUD" "")
(command "-layer" "c" "8" "" "")
(setq SP "Freehand")
(initget 1 "Freehand")
(setq SP (getpoint "\nSpecify first point or [Freehand]: "))
(IF (= SP "Freehand")
(rcloud1)
(rcloud2)
)
(setvar "clayer" templay)
(setvar "osmode" oldos)
(setvar "dimscale" oldim)
(PRINC)
)


(defun rcloud1 (/ chkscale bubscale bubsc)
(setq *ERROR* MyError)
(setq chkscale (getvar "cvport"))
(if (= chkscale 1)
(setvar "dimscale" 1)
)
(setq bubscale (getvar "dimscale")
bubsc (* bubscale 10)
)
(command "revcloud" "a" bubsc bubsc pause)
(while (> (getvar "CmdActive") 0)
(command pause)
)
(command "change" "la" "" "p" "la" "REV_CLOUD" "")
(princ)
)

(defun Rcloud2 ()
(setq *ERROR* MyError)
(prompt
"\nPick cloud boudary: <enter or right click> to finish: "
)
(command "pline" sp)
(while (> (getvar "CmdActive") 0)
(command pause)
(prompt
"\nPick next point: <enter or right click> to finish: "
)
)
(command "pedit" "l" "cl" "")
(setq chkscale (getvar "cvport"))
(if (= chkscale 1)
(setvar "dimscale" 1)
)
(setq bubscale (getvar "dimscale")
bubsc (* bubscale 20)
)
(command "revcloud" "a" bubsc bubsc "o" "last" "")
(PRINC)
)

 

I tried it, and free hand worked for me, but the other way didn't. It said " Cannot convert this object to revision cloud. ".

Tim
A2K4